linux-kernel - Re: [PATCH 1/2] vsprintf: Prevent crash when dereferencing invalid pointers for %pD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190816082000.jmz47bke4it72sv5@pathway.suse.cz>
Date:   Fri, 16 Aug 2019 10:20:00 +0200
From:   Petr Mladek <pmladek@...e.com>
To:     " Justin He (Arm Technology China) " <Justin.He@....com>
Cc:     Andy Shevchenko <andy.shevchenko@...il.com>,
        KeesCook <keescook@...omium.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        "Steven Rostedt (VMware)" <rostedt@...dmis.org>,
        Shuah Khan <shuah@...nel.org>,
        "Tobin C.Harding" <tobin@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] vsprintf: Prevent crash when dereferencing invalid
 pointers for %pD

On Fri 2019-08-09 10:56:04,  Justin He (Arm Technology China)  wrote:
> 
> 
> > -----Original Message-----
> > From: Andy Shevchenko <andy.shevchenko@...il.com>
> > Sent: 2019年8月9日 18:52
> > To: Justin He (Arm Technology China) <Justin.He@....com>
> > Cc: Petr Mladek <pmladek@...e.com>; Andy Shevchenko
> > <andriy.shevchenko@...ux.intel.com>; Sergey Senozhatsky
> > <sergey.senozhatsky@...il.com>; Geert Uytterhoeven
> > <geert+renesas@...der.be>; Linux Kernel Mailing List <linux-
> > kernel@...r.kernel.org>; Thomas Gleixner <tglx@...utronix.de>; Steven
> > Rostedt (VMware) <rostedt@...dmis.org>; Kees Cook
> > <keescook@...omium.org>; Shuah Khan <shuah@...nel.org>; Tobin C.
> > Harding <tobin@...nel.org>
> > Subject: Re: [PATCH 1/2] vsprintf: Prevent crash when dereferencing invalid
> > pointers for %pD
> >
> > On Fri, Aug 9, 2019 at 4:28 AM Jia He <justin.he@....com> wrote:
> > >
> > > Commit 3e5903eb9cff ("vsprintf: Prevent crash when dereferencing
> > invalid
> > > pointers") prevents most crash except for %pD.
> > > There is an additional pointer dereferencing before dentry_name.
> > >
> > > At least, vma->file can be NULL and be passed to printk %pD in
> > > print_bad_pte, which can cause crash.
> > >
> > > This patch fixes it with introducing a new file_dentry_name.
> > >
> >
> > Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>
> >
> > Perhaps you need to add a Fixes tag
> Thanks, Andy
> Fixes: 3e5903eb9cff ("vsprintf: Prevent crash when dereferencing invalid pointers")

I have added the Fixes tag and pushed the patch into printk.git,
branch for-5.4.

Thanks for the fix.

Best Regards,
Petr