linux-kernel - Re: [PATCH v4 4/8] printk: Replace strncmp with str_has

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190816082753.wvaj7hzn4zu3jgjd@pathway.suse.cz>
Date:   Fri, 16 Aug 2019 10:27:53 +0200
From:   Petr Mladek <pmladek@...e.com>
To:     Chuhong Yuan <hslester96@...il.com>
Cc:     Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 4/8] printk: Replace strncmp with str_has_prefix

On Thu 2019-08-15 23:33:01, Chuhong Yuan wrote:
> On Thu, Aug 15, 2019 at 9:52 PM Petr Mladek <pmladek@...e.com> wrote:
> >
> > On Thu 2019-08-15 16:50:33, Sergey Senozhatsky wrote:
> > > On (08/14/19 12:49), Petr Mladek wrote:
> > > > On Fri 2019-08-09 15:10:34, Chuhong Yuan wrote:
> > > > > strncmp(str, const, len) is error-prone because len
> > > > > is easy to have typo.
> > > > > The example is the hard-coded len has counting error
> > > > > or sizeof(const) forgets - 1.
> > > > > So we prefer using newly introduced str_has_prefix()
> > > > > to substitute such strncmp to make code better.
> > > > >
> > > > > Signed-off-by: Chuhong Yuan <hslester96@...il.com>
> > > >
> > > > Reviewed-by: Petr Mladek <pmladek@...e.com>
> > >
> > > Reviewed-by:  Sergey Senozhatsky <sergey.senozhatsky@...il.com>
> >
> > Chuong Yuan, should I take this patch via printk.git? Or will
> > the entire series go via some other tree, please?
> >
> 
> I think that it goes via printk.git is okay, thanks!

The patch is commited into printk.git, branch for-5.4.

Best Regards,
Petr