linux-kernel - Re: [PATCH] usb: gadget: atmel_usba_udc: Mark expected switch fall-through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b0344a15-f0bb-df6a-22a9-36bf432cca3b@microchip.com>
Date:   Fri, 16 Aug 2019 10:27:34 +0000
From:   <Cristian.Birsan@...rochip.com>
To:     <gustavo@...eddedor.com>, <balbi@...nel.org>,
        <gregkh@...uxfoundation.org>, <Nicolas.Ferre@...rochip.com>,
        <alexandre.belloni@...tlin.com>, <Ludovic.Desroches@...rochip.com>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: gadget: atmel_usba_udc: Mark expected switch
 fall-through



On 8/5/19 9:48 PM, Gustavo A. R. Silva wrote:
> External E-Mail
> 
> 
> Mark switch cases where we are expecting to fall through.
> 
> This patch fixes the following warning (Building: at91_dt_defconfig arm):
> 
> drivers/usb/gadget/udc/atmel_usba_udc.c:329:13: warning: this statement may fall through [-Wimplicit-fallthrough=]
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
Acked-by: Cristian Birsan <cristian.birsan@...rochip.com>

> ---
>   drivers/usb/gadget/udc/atmel_usba_udc.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
> index 503d275bc4c4..86ffc8307864 100644
> --- a/drivers/usb/gadget/udc/atmel_usba_udc.c
> +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c
> @@ -327,6 +327,7 @@ static int usba_config_fifo_table(struct usba_udc *udc)
>   	switch (fifo_mode) {
>   	default:
>   		fifo_mode = 0;
> +		/* fall through */
>   	case 0:
>   		udc->fifo_cfg = NULL;
>   		n = 0;
>