linux-kernel - Re: [RFC PATCH 04/15] drivers/acrn: add the basic framework of acrn char device driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190816112820.GV1974@kadam>
Date:   Fri, 16 Aug 2019 14:28:20 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Zhao Yakui <yakui.zhao@...el.com>
Cc:     x86@...nel.org, linux-kernel@...r.kernel.org,
        devel@...verdev.osuosl.org,
        Mingqiang Chi <mingqiang.chi@...el.com>,
        Jack Ren <jack.ren@...el.com>,
        Jason Chen CJ <jason.cj.chen@...el.com>,
        Liu Shuo <shuo.a.liu@...el.com>
Subject: Re: [RFC PATCH 04/15] drivers/acrn: add the basic framework of acrn
 char device driver

On Fri, Aug 16, 2019 at 10:25:45AM +0800, Zhao Yakui wrote:
> +static
> +int acrn_dev_open(struct inode *inodep, struct file *filep)
> +{
> +	pr_info("%s: opening device node\n", __func__);
> +
> +	return 0;
> +}
> +
> +static
> +long acrn_dev_ioctl(struct file *filep,
> +		    unsigned int ioctl_num, unsigned long ioctl_param)
> +{
> +	long ret = 0;
> +
> +	return ret;


This module is mostly stubs and debugging printks...  :(

I looked ahead in the patch series to see if we do something with the
stubs later on and it turns out we do.  Fold the two patches together so
that we don't have to review patches like this one.  Each patch should
do "one thing" which makes sense and can be reviewed independently.

regards,
dan carpenter