linux-kernel - Re: [PATCH v2 2/3] usb: roles: intel_xhci: Supplying software node for the role mux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 16 Aug 2019 16:52:31 +0300
From:   Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     "Rafael J. Wysocki" <rafael@...nel.org>,
        Andy Shevchenko <andy@...radead.org>,
        Hans de Goede <hdegoede@...hat.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Darren Hart <dvhart@...radead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/3] usb: roles: intel_xhci: Supplying software node
 for the role mux

On Fri, Aug 16, 2019 at 04:45:50PM +0300, Andy Shevchenko wrote:
> On Fri, Aug 16, 2019 at 1:45 PM Heikki Krogerus
> <heikki.krogerus@...ux.intel.com> wrote:
> >
> > The primary purpose for this node will be to allow linking
> > the users of the switch to it. The users will be for example
> > USB Type-C connectors. By supplying a reference to this
> > node in the software nodes representing the USB Type-C
> > controllers or connectors, the drivers for those devices can
> > access the switch.
> 
> > +       ret = software_node_register(&intel_xhci_usb_node);
> > +       if (ret)
> > +               return ret;
> > +
> > +       sw_desc.set = intel_xhci_usb_set_role,
> > +       sw_desc.get = intel_xhci_usb_get_role,
> > +       sw_desc.allow_userspace_control = true,
> > +       sw_desc.fwnode = software_node_fwnode(&intel_xhci_usb_node);
> > +
> >         data->role_sw = usb_role_switch_register(dev, &sw_desc);
> >         if (IS_ERR(data->role_sw))
> >                 return PTR_ERR(data->role_sw);
> 
> Sounds to me like more fwnode_handle_put() calls are missed.

True. I'll fix it.

thanks,

-- 
heikki