linux-kernel - Re: [PATCH v3 3/3] i2c/busses/i2c-icy: Add LTC2990 present on 2019 board revision

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190816160916.GA5858@kunai>
Date:   Fri, 16 Aug 2019 18:09:16 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Max Staudt <max@...as.org>
Cc:     linux-i2c@...r.kernel.org, linux-hwmon@...r.kernel.org,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Jean Delvare <jdelvare@...e.com>,
        Guenter Roeck <linux@...ck-us.net>, linux-m68k@...r.kernel.org,
        linux-kernel@...r.kernel.org, glaubitz@...sik.fu-berlin.de
Subject: Re: [PATCH v3 3/3] i2c/busses/i2c-icy: Add LTC2990 present on 2019
 board revision


> > Braces for both blocks. Did you run checkpatch?
> 
> I did, and it didn't say anything.

Hmm, strange, does is complain when you use '--strict'?

> Turns out I misremembered the CodingStyle as having a corner case
> where it doesn't. I'll fix the style - I dislike the above, too ;)

Thanks!

> Yes and no. Now that you mention it - the LTC2990 can be at four
> addresses (0x4c - 0x4f), and there are jumpers (solder pads) on the
> PCB to select its address. Shall I add all 4 addresses to the array?

Yes, please.

> It's also possible that there is no LTC2990 at all (because it's hard
> to solder at home), and that's why we need to probe for it first. I
> believe i2c_new[_client]_device doesn't do probing, but rather assumes
> the device to be there. Correct?

Correct. I assumed the sensor is always there. But it is not and can be
at multiple addresses, so updating the array of addresses is the right
thing to do(tm).


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)