linux-kernel - RE: [PATCH net-next, 2/6] PCI: hv: Add a Hyper-V PCI mini driver for software backchannel interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <871rxl84ry.fsf@vitty.brq.redhat.com>
Date:   Fri, 16 Aug 2019 18:16:17 +0200
From:   Vitaly Kuznetsov <vkuznets@...hat.com>
To:     Haiyang Zhang <haiyangz@...rosoft.com>
Cc:     KY Srinivasan <kys@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
        "sashal\@kernel.org" <sashal@...nel.org>,
        "davem\@davemloft.net" <davem@...emloft.net>,
        "saeedm\@mellanox.com" <saeedm@...lanox.com>,
        "leon\@kernel.org" <leon@...nel.org>,
        "eranbe\@mellanox.com" <eranbe@...lanox.com>,
        "lorenzo.pieralisi\@arm.com" <lorenzo.pieralisi@....com>,
        "bhelgaas\@google.com" <bhelgaas@...gle.com>,
        "linux-pci\@vger.kernel.org" <linux-pci@...r.kernel.org>,
        "linux-hyperv\@vger.kernel.org" <linux-hyperv@...r.kernel.org>,
        "netdev\@vger.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH net-next, 2/6] PCI: hv: Add a Hyper-V PCI mini driver for software backchannel interface

Haiyang Zhang <haiyangz@...rosoft.com> writes:

>
> The pci_hyperv can only be loaded on VMs on Hyper-V and Azure. Other 
> drivers like MLX5e will have symbolic dependency of pci_hyperv if they 
> use functions exported by pci_hyperv. This dependency will cause other 
> drivers fail to load on other platforms, like VMs on KVM. So we created 
> this mini driver, which can be loaded on any platforms to provide the 
> symbolic dependency.

(/me wondering is there a nicer way around this, by using __weak or
something like that...)

In case this stub is the best solution I'd suggest to rename it to
something like PCI_HYPERV_INTERFACE to make it clear it is not a
separate driver (_MINI makes me think so).

-- 
Vitaly