linux-kernel - Re: [PATCH 3/3] soc: fsl: FSL_MC_DPIO selects directly FSL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADRPPNS5BEvFFWe2azOcdikDvLvsUQT03dRF-aahNnD7izPfsQ@mail.gmail.com>
Date:   Fri, 16 Aug 2019 12:03:16 -0500
From:   Li Yang <leoyang.li@....com>
To:     Roy Pledge <roy.pledge@....com>
Cc:     Ioana Ciornei <ioana.ciornei@....com>,
        Laurentiu Tudor <laurentiu.tudor@....com>,
        lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] soc: fsl: FSL_MC_DPIO selects directly FSL_GUTS

On Fri, Aug 16, 2019 at 9:59 AM Roy Pledge <roy.pledge@....com> wrote:
>
> On 8/15/2019 7:09 PM, Li Yang wrote:
> > On Wed, Jul 3, 2019 at 9:58 AM Ioana Ciornei <ioana.ciornei@....com> wrote:
> >> Make FSL_MC_DPIO select directly FSL_GUTS. Without this change we could
> >> be in a situation where both FSL_MC_DPIO and SOC_BUS are enabled but
> >> FSL_GUTS is not.
> >>
> >> Signed-off-by: Ioana Ciornei <ioana.ciornei@....com>
> >> ---
> >>  drivers/soc/fsl/Kconfig | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/soc/fsl/Kconfig b/drivers/soc/fsl/Kconfig
> >> index b6804c04e96f..7e62c1d0aee7 100644
> >> --- a/drivers/soc/fsl/Kconfig
> >> +++ b/drivers/soc/fsl/Kconfig
> >> @@ -22,7 +22,7 @@ config FSL_GUTS
> >>  config FSL_MC_DPIO
> >>          tristate "QorIQ DPAA2 DPIO driver"
> >>          depends on FSL_MC_BUS
> >> -        select SOC_BUS
> >> +        select FSL_GUTS
> > NACK.  Although DPIO only exists on SoCs with the GUTS block for now.
> > There is no direct dependency between the two IPs.  I don't think we
> There isn't a hardware dependency but the DPIO driver does call
> soc_device_match().  If FSL_GUTS isn't present we can't distinguish
> which SoC is being used and the driver isn't able to setup the correct
> stashing destinations.  Is there another mechanism we should be using to
> get this information?

The build will still succeed if SOC_BUS is not defined.  The only
thing is you cannot get the SoC information.  If the driver is really
depending on the SoC information, it probably should "depends on
SOC_BUS" instead of "select SOC_BUS".  My understanding is that the
stashing is an optional performance optimization of DPIO and DPIO can
still be working with out it, right?  If that is the case, we probably
should do nothing here.  Or create another stashing related option to
"depends on SOC_BUS".

Regards,
Leo

> > should add this dependency to make FSL_GUTS not configurable.  Here is
> > some explaination from kernel documentation:
> >
> >         select should be used with care. select will force
> >         a symbol to a value without visiting the dependencies.
> >         By abusing select you are able to select a symbol FOO even
> >         if FOO depends on BAR that is not set.
> >         In general use select only for non-visible symbols
> >         (no prompts anywhere) and for symbols with no dependencies.
> >         That will limit the usefulness but on the other hand avoid
> >         the illegal configurations all over.
> >
> > We probably shouldn't let it select SOC_BUS either from the beginning,
> > as the basic feature of DPIO should still work without defining
> > SOC_BUS.
> >
> > Regards,
> > Leo
> >
> >>          help
> >>           Driver for the DPAA2 DPIO object.  A DPIO provides queue and
> >>           buffer management facilities for software to interact with
> >> --
> >> 1.9.1
> >>
>