linux-kernel - Re: [PATCH] Staging: speakup: spk_types: fixed an unnamed parameter style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 17 Aug 2019 09:00:37 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Matthew Hanzelik <matthew.hanzelik@...il.com>
Cc:     w.d.hubbs@...il.com, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: speakup: spk_types: fixed an unnamed parameter
 style issue

On Sat, Aug 17, 2019 at 02:54:26AM -0400, Matthew Hanzelik wrote:
> Fixed an unnamed parameter style issue.
> 
> Signed-off-by: Matthew Hanzelik <matthew.hanzelik@...il.com>
> ---
>  drivers/staging/speakup/spk_types.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/speakup/spk_types.h b/drivers/staging/speakup/spk_types.h
> index a2fc72c29894..afa64eb9afb4 100644
> --- a/drivers/staging/speakup/spk_types.h
> +++ b/drivers/staging/speakup/spk_types.h
> @@ -189,7 +189,7 @@ struct spk_synth {
>  	void (*flush)(struct spk_synth *synth);
>  	int (*is_alive)(struct spk_synth *synth);
>  	int (*synth_adjust)(struct st_var_header *var);
> -	void (*read_buff_add)(u_char);
> +	void (*read_buff_add)(u_char *add);

You just changed the function prototype from taking a single character,
to taking a pointer to a character, are you sure this is correct?

No other build warnings with this patch enabled?

thanks,

greg k-h