linux-kernel - Re: [PATCH] csky: Fixup ioremap function losing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190818182118.GA30141@infradead.org>
Date:   Sun, 18 Aug 2019 11:21:18 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Guo Ren <guoren@...nel.org>
Cc:     Christoph Hellwig <hch@...radead.org>,
        Arnd Bergmann <arnd@...db.de>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-arch <linux-arch@...r.kernel.org>,
        linux-csky@...r.kernel.org, zhang_jian5@...uatech.com,
        Guo Ren <ren_guo@...ky.com>
Subject: Re: [PATCH] csky: Fixup ioremap function losing

On Sun, Aug 18, 2019 at 10:20:18AM +0800, Guo Ren wrote:
> > > Also change flag VM_ALLOC to VM_IOREMAP in get_vm_area_caller.
> >
> > Looks generally fine, but two comments:
> >
> >  - do you have a need for ioremap_cache?  We are generally try to
> >    phase it out in favour of memremap, and it is generally only used
> >    by arch specific code.
> Yes, some drivers of our customers use ioremap_cache to map phy_addr
> which isn't belong to system memory.

Which driver?  We should move it over to memremap instead of adding
a new ioremap_cache.

> I agree to use GENERIC_IOREMAP, but I want to add csky support
> GENERIC_IOREMAP patch by myself.
> You could remove "csky: use generic ioremap" in your patchset first
> and I'll add support GENERIC_IORMAP patch later.
> Then we won't get confilct :)

Ok.