linux-kernel - Re: [PATCH v6 5/8] iommu: Add bounce page APIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1eea1895-5063-ff33-1dd3-50371d03b3c8@linux.intel.com>
Date:   Sun, 18 Aug 2019 11:07:30 +0800
From:   Lu Baolu <baolu.lu@...ux.intel.com>
To:     Christoph Hellwig <hch@....de>
Cc:     baolu.lu@...ux.intel.com, Joerg Roedel <joro@...tes.org>,
        David Woodhouse <dwmw2@...radead.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>, ashok.raj@...el.com,
        jacob.jun.pan@...el.com, alan.cox@...el.com, kevin.tian@...el.com,
        mika.westerberg@...ux.intel.com, Ingo Molnar <mingo@...hat.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        pengfei.xu@...el.com,
        Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Robin Murphy <robin.murphy@....com>,
        Jonathan Corbet <corbet@....net>,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        Juergen Gross <jgross@...e.com>,
        Stefano Stabellini <sstabellini@...nel.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
        Jacob Pan <jacob.jun.pan@...ux.intel.com>,
        Alan Cox <alan@...ux.intel.com>,
        Mika Westerberg <mika.westerberg@...el.com>
Subject: Re: [PATCH v6 5/8] iommu: Add bounce page APIs

Hi,

On 8/16/19 12:46 PM, Christoph Hellwig wrote:
> On Fri, Aug 16, 2019 at 10:45:13AM +0800, Lu Baolu wrote:
>> Okay. I understand that adding these APIs in iommu.c is not a good idea.
>> And, I also don't think merging the bounce buffer implementation into
>> iommu_map() is feasible since iommu_map() is not DMA API centric.
>>
>> The bounce buffer implementation will eventually be part of DMA APIs
>> defined in dma-iommu.c, but currently those APIs are not ready for x86
>> use yet. So I will put them in iommu/vt-d driver for this time being and
>> will move them to dma-iommu.c later.
> 
> I think they are more or less ready actually, we just need more people
> reviewing the conversions.  Tom just reposted the AMD one which will need
> a few more reviews, and he has an older patchset for intel-iommu as well
> that could use a some more eyes.
> 

Good progress and thanks for the update. I prefer that we merge this
patch series first since it addresses the real thunderbolt
vulnerability.

Best regards,
Lu Baolu