linux-kernel - Re: [PATCH v2] wimax/i2400m: fix a memory leak bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <49AFD2AB-DCA4-470F-96AD-826FAEFDD616@intel.com>
Date:   Sun, 18 Aug 2019 22:22:19 +0000
From:   "Perez-Gonzalez, Inaky" <inaky.perez-gonzalez@...el.com>
To:     David Miller <davem@...emloft.net>
CC:     "wenwen@...uga.edu" <wenwen@...uga.edu>,
        linux-wimax <linux-wimax@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] wimax/i2400m: fix a memory leak bug

This driver should be orphaned. 

While I can’t certainly say nobody is using it, the HW has not been sold for years and it hasn’t been brought to current LK standards. 

If your assesment is the code shall not be used, it’s then another argument towards disconnecting it. 

> On Aug 18, 2019, at 14:12, David Miller <davem@...emloft.net> wrote:
> 
> From: Wenwen Wang <wenwen@...uga.edu>
> Date: Thu, 15 Aug 2019 15:29:51 -0500
> 
>> In i2400m_barker_db_init(), 'options_orig' is allocated through kstrdup()
>> to hold the original command line options. Then, the options are parsed.
>> However, if an error occurs during the parsing process, 'options_orig' is
>> not deallocated, leading to a memory leak bug. To fix this issue, free
>> 'options_orig' before returning the error.
>> 
>> Signed-off-by: Wenwen Wang <wenwen@...uga.edu>
> 
> Applied, but... looking at the rest of this file I hope nobody is actually
> running this code.