linux-kernel - Re: [RFC PATCH 10/15] drivers/acrn: add interrupt injection support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5347e652-9bc1-c465-bc20-488cf0159249@intel.com>
Date:   Mon, 19 Aug 2019 12:59:31 +0800
From:   "Zhao, Yakui" <yakui.zhao@...el.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
        Mingqiang Chi <mingqiang.chi@...el.com>,
        Jason Chen CJ <jason.cj.chen@...el.com>
Subject: Re: [RFC PATCH 10/15] drivers/acrn: add interrupt injection support



On 2019年08月16日 21:12, Dan Carpenter wrote:
> On Fri, Aug 16, 2019 at 10:25:51AM +0800, Zhao Yakui wrote:
>> +	case IC_VM_INTR_MONITOR: {
>> +		struct page *page;
>> +
>> +		ret = get_user_pages_fast(ioctl_param, 1, 1, &page);
>> +		if (unlikely(ret != 1) || !page) {
>                                         ^^^^^^^^
> Not required.

Do you mean that it is enough to check the condition of "ret != 1"?
OK. It will be removed.


> 
>> +			pr_err("acrn-dev: failed to pin intr hdr buffer!\n");
>> +			return -ENOMEM;
>> +		}
>> +
>> +		ret = hcall_vm_intr_monitor(vm->vmid, page_to_phys(page));
>> +		if (ret < 0) {
>> +			pr_err("acrn-dev: monitor intr data err=%ld\n", ret);
>> +			return -EFAULT;
>> +		}
>> +		break;
>> +	}
>> +
> 
> regards,
> dan carpenter
>