linux-kernel - Re: [patch 42/44] posix-cpu-timers: Move state tracking to struct posix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 19 Aug 2019 21:13:27 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Oleg Nesterov <oleg@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        John Stultz <john.stultz@...aro.org>,
        Frederic Weisbecker <fweisbec@...il.com>,
        Anna-Maria Behnsen <anna-maria@...utronix.de>
Subject: Re: [patch 42/44] posix-cpu-timers: Move state tracking to struct
 posix_cputimers


* Thomas Gleixner <tglx@...utronix.de> wrote:

> Put it where it belongs and cleanup the ifdeffery in fork completely.

s/cleanup
 /clean up

>   * posix_cputimers - Container for posix CPU timer related data
>   * @expiries:		Earliest-expiration cache array based
> + * @timers_active:	Timers are queued.
> + * @expiry_active:	Timer expiry is active. Used for
> + *			process wide timers to avoid multiple
> + *			trying to handle expiry

'to avoid multiple trying to handle expiry'?

Should this be: 'to avoid multiple tasks trying to handle expiry'?

> +	 * Check whether posix cpu timers are active. If not the thread
> +	 * group accounting is not active either. Lockless check.

s/cpu timers
 /CPU timers

Thanks,

	Ingo