linux-kernel - Re: [PATCH -next] clk: st: clkgen-pll: remove unused variable 'st_pll3200c32_407

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1566192546052.96439@st.com>
Date:   Mon, 19 Aug 2019 05:29:06 +0000
From:   Gabriel FERNANDEZ <gabriel.fernandez@...com>
To:     Stephen Boyd <sboyd@...nel.org>,
        YueHaibing <yuehaibing@...wei.com>,
        "allison@...utok.net" <allison@...utok.net>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "mturquette@...libre.com" <mturquette@...libre.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>
Subject: Re: [PATCH -next] clk: st: clkgen-pll: remove unused variable
 'st_pll3200c32_407_a0'

Acked-by: Gabriel Fernandez <gabriel.fernandez@...com>
________________________________________
From: Stephen Boyd <sboyd@...nel.org>
Sent: Friday, August 16, 2019 7:36 PM
To: YueHaibing; allison@...utok.net; gregkh@...uxfoundation.org; mturquette@...libre.com; Gabriel FERNANDEZ
Cc: linux-kernel@...r.kernel.org; linux-clk@...r.kernel.org; YueHaibing
Subject: Re: [PATCH -next] clk: st: clkgen-pll: remove unused variable 'st_pll3200c32_407_a0'

Quoting YueHaibing (2019-08-16 06:55:23)
> drivers/clk/st/clkgen-pll.c:64:37: warning:
>  st_pll3200c32_407_a0 defined but not used [-Wunused-const-variable=]
>
> It is never used, so can be removed.
>
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---

Adding Gabriel, please ack/review.

>  drivers/clk/st/clkgen-pll.c | 13 -------------
>  1 file changed, 13 deletions(-)
>
> diff --git a/drivers/clk/st/clkgen-pll.c b/drivers/clk/st/clkgen-pll.c
> index d8a688b..c3952f2 100644
> --- a/drivers/clk/st/clkgen-pll.c
> +++ b/drivers/clk/st/clkgen-pll.c
> @@ -61,19 +61,6 @@ static const struct clk_ops stm_pll3200c32_ops;
>  static const struct clk_ops stm_pll3200c32_a9_ops;
>  static const struct clk_ops stm_pll4600c28_ops;
>
> -static const struct clkgen_pll_data st_pll3200c32_407_a0 = {
> -       /* 407 A0 */
> -       .pdn_status     = CLKGEN_FIELD(0x2a0,   0x1,                    8),
> -       .pdn_ctrl       = CLKGEN_FIELD(0x2a0,   0x1,                    8),
> -       .locked_status  = CLKGEN_FIELD(0x2a0,   0x1,                    24),
> -       .ndiv           = CLKGEN_FIELD(0x2a4,   C32_NDIV_MASK,          16),
> -       .idf            = CLKGEN_FIELD(0x2a4,   C32_IDF_MASK,           0x0),
> -       .num_odfs = 1,
> -       .odf            = { CLKGEN_FIELD(0x2b4, C32_ODF_MASK,           0) },
> -       .odf_gate       = { CLKGEN_FIELD(0x2b4, 0x1,                    6) },
> -       .ops            = &stm_pll3200c32_ops,
> -};
> -
>  static const struct clkgen_pll_data st_pll3200c32_cx_0 = {
>         /* 407 C0 PLL0 */
>         .pdn_status     = CLKGEN_FIELD(0x2a0,   0x1,                    8),