linux-kernel - Re: [PATCH] fs/xfs: Fix return code of xfs_break_leased

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190819231031.GB1037350@magnolia>
Date:   Mon, 19 Aug 2019 16:10:31 -0700
From:   "Darrick J. Wong" <darrick.wong@...cle.com>
To:     ira.weiny@...el.com
Cc:     linux-xfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs/xfs: Fix return code of xfs_break_leased_layouts()

On Mon, Aug 19, 2019 at 02:39:18PM -0700, ira.weiny@...el.com wrote:
> From: Ira Weiny <ira.weiny@...el.com>
> 
> The parens used in the while loop would result in error being assigned
> the value 1 rather than the intended errno value.
> 
> This is required to return -ETXTBSY from follow on break_layout()
> changes.
> 
> Signed-off-by: Ira Weiny <ira.weiny@...el.com>

Doh.
Reviewed-by: Darrick J. Wong <darrick.wong@...cle.com>

--D

> ---
>  fs/xfs/xfs_pnfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_pnfs.c b/fs/xfs/xfs_pnfs.c
> index 0c954cad7449..a339bd5fa260 100644
> --- a/fs/xfs/xfs_pnfs.c
> +++ b/fs/xfs/xfs_pnfs.c
> @@ -32,7 +32,7 @@ xfs_break_leased_layouts(
>  	struct xfs_inode	*ip = XFS_I(inode);
>  	int			error;
>  
> -	while ((error = break_layout(inode, false) == -EWOULDBLOCK)) {
> +	while ((error = break_layout(inode, false)) == -EWOULDBLOCK) {
>  		xfs_iunlock(ip, *iolock);
>  		*did_unlock = true;
>  		error = break_layout(inode, true);
> -- 
> 2.20.1
>