linux-kernel - Re: [PATCH 1/3] media: dt-bindings: Update bindings for Cadence CSI2RX version 2.1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <A3DAF408-887A-4913-B620-959BCD4E98D8@global.cadence.com>
Date:   Mon, 19 Aug 2019 07:16:04 +0000
From:   Jan Kotas <jank@...ence.com>
To:     Rob Herring <robh@...nel.org>
CC:     Jan Kotas <jank@...ence.com>,
        Maxime Ripard <maxime.ripard@...tlin.com>,
        "mchehab@...nel.org" <mchehab@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        Rafal Ciepiela <rafalc@...ence.com>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] media: dt-bindings: Update bindings for Cadence
 CSI2RX version 2.1



> On 16 Aug 2019, at 23:18, Rob Herring <robh@...nel.org> wrote:
> 
> 
> On Thu, Jul 25, 2019 at 11:26:46AM +0100, Jan Kotas wrote:
>> This patch adds a DT bindings documentation for
>> Cadence CSI2RX v2.1 controller.
> 
> And 1.3?

OK, I’ll update the commit description.
>> Required properties:
>> -  - compatible: must be set to "cdns,csi2rx" and an SoC-specific compatible
>> +  - compatible: must be set to "cdns,csi2rx" or "cdns,csi2rx-1.3"
>> +    for version 1.3 of the controller, "cdns,csi2rx-2.1" for v2.1
>> +    and an SoC-specific compatible
> 
> This wording is now not clear that an SoC-specific compatible is always 
> required or just for 2.1. Please format one compatible per line.

OK, I will fix it in v2.

Thank you for the comments.

Regards,
Jan