linux-kernel - Re: [PATCH] ARM: dts: imx7d: cl-som-imx7: make ethernet work again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 19 Aug 2019 09:51:22 +0200
From:   Shawn Guo <shawnguo@...nel.org>
To:     André Draszik <git@...red.net>
Cc:     linux-kernel@...r.kernel.org, Ilya Ledvich <ilya@...pulab.co.il>,
        Igor Grinberg <grinberg@...pulab.co.il>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] ARM: dts: imx7d: cl-som-imx7: make ethernet work again

On Fri, Aug 09, 2019 at 04:12:27AM +0100, André Draszik wrote:
> Recent changes to the atheros at803x driver caused
> ethernet to stop working on this board.
> In particular commit 6d4cd041f0af
> ("net: phy: at803x: disable delay only for RGMII mode")
> and commit cd28d1d6e52e
> ("net: phy: at803x: Disable phy delay for RGMII mode")
> fix the AR8031 driver to configure the phy's (RX/TX)
> delays as per the 'phy-mode' in the device tree.
> 
> This now prevents ethernet from working on this board.
> 
> It used to work before those commits, because the
> AR8031 comes out of reset with RX delay enabled, and
> the at803x driver didn't touch the delay configuration
> at all when "rgmii" mode was selected, and because
> arch/arm/mach-imx/mach-imx7d.c:ar8031_phy_fixup()
> unconditionally enables TX delay.
> 
> Since above commits ar8031_phy_fixup() also has no
> effect anymore, and the end-result is that all delays
> are disabled in the phy, no ethernet.
> 
> Update the device tree to restore functionality.
> 
> Signed-off-by: André Draszik <git@...red.net>
> CC: Ilya Ledvich <ilya@...pulab.co.il>
> CC: Igor Grinberg <grinberg@...pulab.co.il>
> CC: Rob Herring <robh+dt@...nel.org>
> CC: Mark Rutland <mark.rutland@....com>
> CC: Shawn Guo <shawnguo@...nel.org>
> CC: Sascha Hauer <s.hauer@...gutronix.de>
> CC: Pengutronix Kernel Team <kernel@...gutronix.de>
> CC: Fabio Estevam <festevam@...il.com>
> CC: NXP Linux Team <linux-imx@....com>
> CC: devicetree@...r.kernel.org
> CC: linux-arm-kernel@...ts.infradead.org

Applied, thanks.