linux-kernel - Re: [PATCH] ARM: imx: stop adjusting ar8031 phy tx delay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190819075139.GF5999@X250>
Date:   Mon, 19 Aug 2019 09:51:40 +0200
From:   Shawn Guo <shawnguo@...nel.org>
To:     André Draszik <git@...red.net>
Cc:     linux-kernel@...r.kernel.org, Russell King <linux@...linux.org.uk>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Leonard Crestez <leonard.crestez@....com>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] ARM: imx: stop adjusting ar8031 phy tx delay

On Fri, Aug 09, 2019 at 04:12:56AM +0100, André Draszik wrote:
> Recent changes to the Atheros at803x driver cause
> the approach taken here to stop working because
> commit 6d4cd041f0af
> ("net: phy: at803x: disable delay only for RGMII mode")
> and commit cd28d1d6e52e
> ("net: phy: at803x: Disable phy delay for RGMII mode")
> fix the AR8031 driver to configure the phy's (RX/TX)
> delays as per the 'phy-mode' in the device tree.
> 
> In particular, the phy tx (and rx) delays are updated
> again as per the 'phy-mode' *after* the code in here
> runs.
> 
> Things worked before above commits, because the AR8031
> comes out of reset with RX delay enabled, and the
> at803x driver didn't touch the delay configuration at
> all when "rgmii" mode was selected.
> 
> It appears the code in here tries to make device
> trees work that incorrectly specify "rgmii", but
> that can't work any more and it is imperative since
> above commits to have the phy-mode configured
> correctly in the device tree.
> 
> I suspect there are a few imx7d based boards using
> the ar8031 phy and phy-mode = "rgmii", but given I
> don't know which ones exactly, I am not in a
> position to update the respective device trees.
> 
> Hence this patch is simply removing the superfluous
> code from the imx7d initialisation. An alternative
> could be to add a warning instead, but that would
> penalize all boards that have been updated already.
> 
> Signed-off-by: André Draszik <git@...red.net>
> CC: Russell King <linux@...linux.org.uk>
> CC: Shawn Guo <shawnguo@...nel.org>
> CC: Sascha Hauer <s.hauer@...gutronix.de>
> CC: Pengutronix Kernel Team <kernel@...gutronix.de>
> CC: Fabio Estevam <festevam@...il.com>
> CC: NXP Linux Team <linux-imx@....com>
> CC: Kate Stewart <kstewart@...uxfoundation.org>
> CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> CC: Thomas Gleixner <tglx@...utronix.de>
> CC: Leonard Crestez <leonard.crestez@....com>
> CC: linux-arm-kernel@...ts.infradead.org

Applied, thanks.