linux-kernel - Re: wifi on Motorola Droid 4 in 5.3-rc2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 19 Aug 2019 11:24:14 +0200
From:   Pavel Machek <pavel@....cz>
To:     Michael Nazzareno Trimarchi <michael@...rulasolutions.com>
Cc:     kernel list <linux-kernel@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        Linux OMAP Mailing List <linux-omap@...r.kernel.org>,
        Tony Lindgren <tony@...mide.com>,
        Sebastian Reichel <sre@...nel.org>, nekit1000@...il.com,
        mpartap@....net, Merlijn Wajer <merlijn@...zup.org>,
        "open list:TI WILINK WIRELES..." <linux-wireless@...r.kernel.org>
Subject: Re: wifi on Motorola Droid 4 in 5.3-rc2

Hi!

> > [   13.653778] panel-dsi-cm 58004000.encoder:display: using lookup
> > tables for GPIO lookup
> > [   13.661834] panel-dsi-cm 58004000.encoder:display: No GPIO consumer
> > te found
> > [   14.756622] ------------[ cut here ]------------
> > [   14.761352] WARNING: CPU: 0 PID: 20 at
> > /data/fast/l/k/drivers/net/wireless/ti/wlcore/sdio.c:86
> > wl12xx_sdio_raw_read+0xa8/0x128
> > [   14.772888] Modules linked in:
> > [   14.776062] CPU: 0 PID: 20 Comm: kworker/0:1 Tainted: G        W
> > 5.3.0-rc4-58571-gdbaece1 #85
> > [   14.783630] Hardware name: Generic OMAP4 (Flattened Device Tree)
> > [   14.791381] Workqueue: events request_firmware_work_func
> 
> You have a timeout here. Can be that your reset sequence of the wifi
> is not optimal because
> is not responding?

I tried delays and printks... WL12XX_REG_FUSE_BD_ADDR_1 read fails,
and retrying does not really help. If you have idea how to debug/fix
this, let me know...

Best regards,
								Pavel

diff --git a/drivers/net/wireless/ti/wl12xx/main.c b/drivers/net/wireless/ti/wl12xx/main.c
index 3c9c623..afb294a 100644
--- a/drivers/net/wireless/ti/wl12xx/main.c
+++ b/drivers/net/wireless/ti/wl12xx/main.c
@@ -1505,24 +1505,40 @@ static int wl12xx_get_fuse_mac(struct wl1271 *wl)
 {
 	u32 mac1, mac2;
 	int ret;
-
+	
+	mdelay(1);
+	printk("get_fuse_mac: %d\n", __LINE__);
 	ret = wlcore_set_partition(wl, &wl->ptable[PART_DRPW]);
 	if (ret < 0)
 		goto out;
 
+	mdelay(1);
+	printk("get_fuse_mac: %d\n", __LINE__);
+	ret = wlcore_read32(wl, WL12XX_REG_FUSE_BD_ADDR_1, &mac1);
+	if (ret < 0) {
+	printk("get_fuse_mac: X %d\n", __LINE__);
+	ret = wlcore_read32(wl, WL12XX_REG_FUSE_BD_ADDR_1, &mac1);
+	if (ret < 0) {
+	printk("get_fuse_mac: XX %d\n", __LINE__);
 	ret = wlcore_read32(wl, WL12XX_REG_FUSE_BD_ADDR_1, &mac1);
 	if (ret < 0)
 		goto out;
+	}
+	}
+	
 
+	printk("get_fuse_mac: %d\n", __LINE__);
 	ret = wlcore_read32(wl, WL12XX_REG_FUSE_BD_ADDR_2, &mac2);
 	if (ret < 0)
 		goto out;
 
+	printk("get_fuse_mac: %d\n", __LINE__);
 	/* these are the two parts of the BD_ADDR */
 	wl->fuse_oui_addr = ((mac2 & 0xffff) << 8) +
 		((mac1 & 0xff000000) >> 24);
 	wl->fuse_nic_addr = mac1 & 0xffffff;
 
+	printk("get_fuse_mac: %d\n", __LINE__);
 	ret = wlcore_set_partition(wl, &wl->ptable[PART_DOWN]);
 
 out:

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)