linux-kernel - RE: [PATCH v3] Bluetooth: btusb: Fix suspend issue for Realtek devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <805C62CFCC3D8947A436168B9486C77DEE396F3E@RTITMBSVM03.realtek.com.tw>
Date:   Mon, 19 Aug 2019 09:28:50 +0000
From:   Max Chou <max.chou@...ltek.com>
To:     Marcel Holtmann <marcel@...tmann.org>,
        alex_lu <alex_lu@...lsil.com.cn>
CC:     Johan Hedberg <johan.hedberg@...il.com>,
        "linux-bluetooth@...r.kernel.org" <linux-bluetooth@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v3] Bluetooth: btusb: Fix suspend issue for Realtek devices

Dear Kernel Maintainer Marcel, 
Sorry for the inconvenience. For the original target, this patch is edited for low power consumption hence controller should not receive DEVICE_REMOTE_WAKE_UP that it's able to save power in suspend mode because BT wake-up function is disabled.
In upstream driver, there should be higher priority for function rather than performance. In other words, this patch can meet the low power consumption in suspend mode but will lose BT wake-up function. It is not a good idea for that. Please help to revert this modification. 
Thank you.


BRs,
Max


-----Original Message-----
From: Marcel Holtmann <marcel@...tmann.org> 
Sent: Wednesday, August 14, 2019 9:54 PM
To: alex_lu <alex_lu@...lsil.com.cn>
Cc: Johan Hedberg <johan.hedberg@...il.com>; linux-bluetooth@...r.kernel.org; linux-kernel@...r.kernel.org; Max Chou <max.chou@...ltek.com>
Subject: Re: [PATCH v3] Bluetooth: btusb: Fix suspend issue for Realtek devices

Hi Alex,

> From the perspective of controller, global suspend means there is no 
> SET_FEATURE (DEVICE_REMOTE_WAKEUP) and controller would drop the 
> firmware. It would consume less power. So we should not send this kind 
> of SET_FEATURE when host goes to suspend state.
> Otherwise, when making device enter selective suspend, host should 
> send SET_FEATURE to make sure the firmware remains.
> 
> Signed-off-by: Alex Lu <alex_lu@...lsil.com.cn>
> ---
> Changes in v3:
>  - Change to fit for bluetooth-next
> Changes in v2:
>  - Change flag to be more descriptive
>  - Delete pointless #ifdef CONFIG_BT_HCIBTUSB_RTL and #endif
> 
> drivers/bluetooth/btusb.c | 34 ++++++++++++++++++++++++++++++----
> 1 file changed, 30 insertions(+), 4 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel


------Please consider the environment before printing this e-mail.