linux-kernel - Re: [PATCH 2/2] uacce: add uacce module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190819102250.GA2030@kroah.com>
Date:   Mon, 19 Aug 2019 12:22:50 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     "zhangfei.gao@...mail.com" <zhangfei.gao@...mail.com>
Cc:     Zhangfei Gao <zhangfei.gao@...aro.org>,
        Arnd Bergmann <arnd@...db.de>,
        linux-accelerators@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
        Kenneth Lee <liguozhu@...ilicon.com>,
        Zaibo Xu <xuzaibo@...wei.com>,
        Zhou Wang <wangzhou1@...ilicon.com>
Subject: Re: [PATCH 2/2] uacce: add uacce module

On Mon, Aug 19, 2019 at 05:09:23PM +0800, zhangfei.gao@...mail.com wrote:
> Hi, Greg
> 
> Thanks for your kind suggestion.
> 
> On 2019/8/15 下午10:12, Greg Kroah-Hartman wrote:
> > On Wed, Aug 14, 2019 at 05:34:25PM +0800, Zhangfei Gao wrote:
> > > diff --git a/include/uapi/misc/uacce.h b/include/uapi/misc/uacce.h
> > > new file mode 100644
> > > index 0000000..44a0a5d
> > > --- /dev/null
> > > +++ b/include/uapi/misc/uacce.h
> > > @@ -0,0 +1,44 @@
> > > +/* SPDX-License-Identifier: GPL-2.0-or-later */
> > > +#ifndef _UAPIUUACCE_H
> > > +#define _UAPIUUACCE_H
> > > +
> > > +#include <linux/types.h>
> > > +#include <linux/ioctl.h>
> > > +
> > > +#define UACCE_CLASS_NAME	"uacce"
> > Why is this in a uapi file?
> User app need get attribute from /sys/class,
> For example: /sys/class/uacce/hisi_zip-0/xxx
> UACCE_CLASS_NAME here tells app which subsystem to open,
> /sys/class/subsystem/

But that never comes from a uapi file.  No other subsystem does this.

thanks,

greg k-h