linux-kernel - Re: [PATCH 2/3] Documentation: Describe V4L2_CID_PIXEL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPybu_04Ho1h4WeZTR8GjKD-Q2USWSdO90spq+ECw5Lt5kfKOQ@mail.gmail.com>
Date:   Mon, 19 Aug 2019 15:44:16 +0200
From:   Ricardo Ribalda Delgado <ribalda@...nel.org>
To:     Philipp Zabel <p.zabel@...gutronix.de>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Hans Verkuil <hverkuil-cisco@...all.nl>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        linux-media <linux-media@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] Documentation: Describe V4L2_CID_PIXEL_SIZE

Completely agree. Maybe we should call the control unit cell size?, in
case in the future we need a control for the light sensitive area.

Best regards

On Mon, Aug 19, 2019 at 3:42 PM Philipp Zabel <p.zabel@...gutronix.de> wrote:
>
> On Mon, 2019-08-19 at 14:17 +0200, Ricardo Ribalda Delgado wrote:
> > New control to pass to userspace the width/height of a pixel. Which is
> > needed for 3D calibration and lens selection.
> >
> > Signed-off-by: Ricardo Ribalda Delgado <ribalda@...nel.org>
> > ---
> >  Documentation/media/uapi/v4l/ext-ctrls-camera.rst | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/Documentation/media/uapi/v4l/ext-ctrls-camera.rst b/Documentation/media/uapi/v4l/ext-ctrls-camera.rst
> > index 51c1d5c9eb00..670c57a6f622 100644
> > --- a/Documentation/media/uapi/v4l/ext-ctrls-camera.rst
> > +++ b/Documentation/media/uapi/v4l/ext-ctrls-camera.rst
> > @@ -510,6 +510,12 @@ enum v4l2_scene_mode -
> >      value down. A value of zero stops the motion if one is in progress
> >      and has no effect otherwise.
> >
> > +``V4L2_CID_PIXEL_SIZE (struct)``
> > +    This control returns the pixel size in nanometres. The struct provides
> > +    the width and the height in separated fields to take into consideration
> > +    asymmetric pixels and/or hardware binning.
> > +    This control is required for automatic calibration of the sensor.
> > +
> >  .. [#f1]
> >     This control may be changed to a menu control in the future, if more
> >     options are required.
>
> I suppose this is a common term, but should it be mentioned that pixel
> size is the same as unit cell size, and not necessarily the size of the
> light sensitive area? Just in case the effective fill-factor is < 100%.
>
> regards
> Philipp