linux-kernel - Re: [PATCH] video: fbdev: pvr2fb: remove unnecessary comparison of unsigned integer with

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7c233700-a6b2-54fd-e86d-a11583bb3ec3@samsung.com>
Date:   Mon, 19 Aug 2019 16:01:57 +0200
From:   Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] video: fbdev: pvr2fb: remove unnecessary comparison of
 unsigned integer with < 0


On 7/22/19 10:33 PM, Gustavo A. R. Silva wrote:
> There is no need to compare *var->xoffset* or *var->yoffset* with < 0
> because such variables are of type unsigned, making it impossible to
> hold a negative value.
> 
> Fix this by removing such comparisons.
> 
> Addresses-Coverity-ID: 1451964 ("Unsigned compared against 0")
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
Patch queued for v5.4, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics