linux-kernel - Re: [Linux-kernel-mentees][PATCH v6 1/2] sgi-gru: Convert put_page() to put_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190819125611.GA5808@hpe.com>
Date:   Mon, 19 Aug 2019 07:56:11 -0500
From:   Dimitri Sivanich <sivanich@....com>
To:     Bharath Vedartham <linux.bhar@...il.com>
CC:     <sivanich@....com>, <jhubbard@...dia.com>, <jglisse@...hat.com>,
        <ira.weiny@...el.com>, <gregkh@...uxfoundation.org>,
        <arnd@...db.de>, <william.kucharski@...cle.com>, <hch@....de>,
        <inux-kernel@...r.kernel.org>, <linux-mm@...ck.org>,
        <linux-kernel-mentees@...ts.linuxfoundation.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [Linux-kernel-mentees][PATCH v6 1/2] sgi-gru: Convert put_page()
 to put_user_page*()

Reviewed-by: Dimitri Sivanich <sivanich@....com>

On Mon, Aug 19, 2019 at 01:08:54AM +0530, Bharath Vedartham wrote:
> For pages that were retained via get_user_pages*(), release those pages
> via the new put_user_page*() routines, instead of via put_page() or
> release_pages().
> 
> This is part a tree-wide conversion, as described in commit fc1d8e7cca2d
> ("mm: introduce put_user_page*(), placeholder versions").
> 
> Cc: Ira Weiny <ira.weiny@...el.com>
> Cc: John Hubbard <jhubbard@...dia.com>
> Cc: Jérôme Glisse <jglisse@...hat.com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Dimitri Sivanich <sivanich@....com>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: William Kucharski <william.kucharski@...cle.com>
> Cc: Christoph Hellwig <hch@....de>
> Cc: linux-kernel@...r.kernel.org
> Cc: linux-mm@...ck.org
> Cc: linux-kernel-mentees@...ts.linuxfoundation.org
> Reviewed-by: Ira Weiny <ira.weiny@...el.com>
> Reviewed-by: John Hubbard <jhubbard@...dia.com>
> Reviewed-by: William Kucharski <william.kucharski@...cle.com>
> Signed-off-by: Bharath Vedartham <linux.bhar@...il.com>
> ---
>  drivers/misc/sgi-gru/grufault.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/sgi-gru/grufault.c b/drivers/misc/sgi-gru/grufault.c
> index 4b713a8..61b3447 100644
> --- a/drivers/misc/sgi-gru/grufault.c
> +++ b/drivers/misc/sgi-gru/grufault.c
> @@ -188,7 +188,7 @@ static int non_atomic_pte_lookup(struct vm_area_struct *vma,
>  	if (get_user_pages(vaddr, 1, write ? FOLL_WRITE : 0, &page, NULL) <= 0)
>  		return -EFAULT;
>  	*paddr = page_to_phys(page);
> -	put_page(page);
> +	put_user_page(page);
>  	return 0;
>  }
>  
> -- 
> 2.7.4
>