linux-kernel - Re: Re: Re: Re: Re: [PATCH] RDMA/siw: Fix compiler warnings on 32-bit due to u64/pointer abuse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <OFFE3BC87B.CF197FD5-ON0025845B.0059957B-0025845B.005A903D@notes.na.collabserv.com>
Date:   Mon, 19 Aug 2019 16:29:11 +0000
From:   "Bernard Metzler" <BMT@...ich.ibm.com>
To:     "Jason Gunthorpe" <jgg@...pe.ca>
Cc:     "Geert Uytterhoeven" <geert@...ux-m68k.org>,
        "Doug Ledford" <dledford@...hat.com>, linux-rdma@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: Re: Re: Re: Re: [PATCH] RDMA/siw: Fix compiler warnings on 32-bit due
 to u64/pointer abuse

-----"Jason Gunthorpe" <jgg@...pe.ca> wrote: -----

>To: "Bernard Metzler" <BMT@...ich.ibm.com>
>From: "Jason Gunthorpe" <jgg@...pe.ca>
>Date: 08/19/2019 06:05PM
>Cc: "Geert Uytterhoeven" <geert@...ux-m68k.org>, "Doug Ledford"
><dledford@...hat.com>, linux-rdma@...r.kernel.org,
>linux-kernel@...r.kernel.org
>Subject: [EXTERNAL] Re: Re: Re: Re: [PATCH] RDMA/siw: Fix compiler
>warnings on 32-bit due to u64/pointer abuse
>
>On Mon, Aug 19, 2019 at 03:54:56PM +0000, Bernard Metzler wrote:
>
>> Absolutely. But these addresses are conveyed through the
>> API as unsigned 64 during post_send(), and land in the siw
>> send queue as is. During send queue processing, these addresses
>> must be interpreted according to its context and transformed
>> (casted) back to the callers intention. I frankly do not
>> know what we can do differently... The representation of
>> all addresses as unsigned 64 is given. Sorry for the confusion.
>
>send work does not have pointers in it, so I'm confused what this is
>about. Does siw allow userspace to stick an ordinary pointer for the
>SG list?

Right a user references a buffer by address and local key it
got during reservation of that buffer. The user can provide any
VA between start of that buffer and registered length. 

>
>The code paths here must be totally different, so there should be
>different types and functions for each case.

Yes, there is a function to process application memory (siw_rx_umem),
to process a kernel PBL (siw_rx_pbl), and one to process kernel
addresses (siw_rx_kva). Before running that function, the API
representation of the current SGE gets translated into target
buffer representation.

Thanks and best regards,
Bernard.