linux-kernel - Re: [PATCH] ACPI/PCI: Remove surplus parentheses from a return statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190819172543.GA23903@e119886-lin.cambridge.arm.com>
Date:   Mon, 19 Aug 2019 18:25:43 +0100
From:   Andrew Murray <andrew.murray@....com>
To:     Krzysztof Wilczynski <kw@...ux.com>
Cc:     Bjorn Helgaas <helgaas@...nel.org>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>, linux-pci@...r.kernel.org,
        linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ACPI/PCI: Remove surplus parentheses from a return
 statement

On Mon, Aug 19, 2019 at 03:53:24PM +0200, Krzysztof Wilczynski wrote:
> Remove unnecessary parentheses enclosing the value in a return
> statement in the drivers/acpi/pci_link.c.
> 
> Signed-off-by: Krzysztof Wilczynski <kw@...ux.com>
> ---
>  drivers/acpi/pci_link.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/acpi/pci_link.c b/drivers/acpi/pci_link.c
> index db11f7771ef1..00a6da2121be 100644
> --- a/drivers/acpi/pci_link.c
> +++ b/drivers/acpi/pci_link.c
> @@ -661,7 +661,7 @@ int acpi_pci_link_allocate_irq(acpi_handle handle, int index, int *triggering,
>  	ACPI_DEBUG_PRINT((ACPI_DB_INFO,
>  			  "Link %s is referenced\n",
>  			  acpi_device_bid(link->device)));
> -	return (link->irq.active);
> +	return link->irq.active;
>  }
>  
>  /*
> @@ -712,7 +712,7 @@ int acpi_pci_link_free_irq(acpi_handle handle)
>  		acpi_evaluate_object(link->device->handle, "_DIS", NULL, NULL);
>  
>  	mutex_unlock(&acpi_link_lock);
> -	return (link->irq.active);
> +	return link->irq.active;

It looks like these parentheses were left over after a patch that removed some
macros:

 ad550d98d3317 ("ACPI: delete tracing macros from drivers/acpi/*.c")

I can't see any you've missed so:

Reviewed-by: Andrew Murray <andrew.murray@....com>


>  }
>  
>  /* --------------------------------------------------------------------------
> -- 
> 2.22.1
>