linux-kernel - Re: [PATCH 10/22] arm64: dts: qcom: pm8150b: Add pon and adc nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190819175628.6914A22CEB@mail.kernel.org>
Date:   Mon, 19 Aug 2019 10:56:27 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Vinod Koul <vkoul@...nel.org>
Cc:     Andy Gross <agross@...nel.org>, linux-arm-msm@...r.kernel.org,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        sibis@...eaurora.org, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 10/22] arm64: dts: qcom: pm8150b: Add pon and adc nodes

Quoting Vinod Koul (2019-08-19 10:43:31)
> On 14-08-19, 10:08, Stephen Boyd wrote:
> > 
> > > 
> > > diff --git a/arch/arm64/boot/dts/qcom/pm8150b.dtsi b/arch/arm64/boot/dts/qcom/pm8150b.dtsi
> > > index c0a678b0f159..846197bd65cd 100644
> > > --- a/arch/arm64/boot/dts/qcom/pm8150b.dtsi
> > > +++ b/arch/arm64/boot/dts/qcom/pm8150b.dtsi
> > > @@ -2,6 +2,7 @@
> > >  // Copyright (c) 2017-2019, The Linux Foundation. All rights reserved.
> > >  // Copyright (c) 2019, Linaro Limited
> > >  
> > > +#include <dt-bindings/iio/qcom,spmi-vadc.h>
> > >  #include <dt-bindings/interrupt-controller/irq.h>
> > >  #include <dt-bindings/spmi/spmi.h>
> > >  
> > > @@ -11,6 +12,59 @@
> > >                 reg = <0x2 SPMI_USID>;
> > >                 #address-cells = <1>;
> > >                 #size-cells = <0>;
> > > +
> > > +               pon@800 {
> > 
> > Maybe pon node name should be 'key' or 'power-on'?
> 
> pon stands for power on device. See Documentation/devicetree/bindings/power/reset/qcom,pon.txt
> 

Right. I was hoping for a more standard node name vs. an acronym that's
SoC specific.