linux-kernel - Re: [PATCH 2/2] staging: rtl8192e: rtllib_crypt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <767c52c9-71ba-6639-631d-6f3cb0d6951c@lwfinger.net>
Date:   Mon, 19 Aug 2019 12:57:57 -0500
From:   Larry Finger <Larry.Finger@...inger.net>
To:     Christina Quast <contact@...istina-quast.de>,
        ard.biesheuvel@...aro.org
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Payal Kshirsagar <payal.s.kshirsagar.98@...il.com>,
        Eric Biggers <ebiggers@...gle.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        Anushka Shukla <anushkacharu9@...il.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Zach Turner <turnerzdp@...il.com>,
        linux-wireless@...r.kernel.org,
        Johannes Berg <johannes@...solutions.net>,
        "David S. Miller" <davem@...emloft.net>,
        linux-crypto@...r.kernel.org
Subject: Re: [PATCH 2/2] staging: rtl8192e: rtllib_crypt_ccmp.c: Use crypto
 API ccm(aes)

On 8/16/19 1:59 AM, Christina Quast wrote:
> Use ccm(aes) aead transform instead of invoking the AES block cipher
> block by block.
> 
> Signed-off-by: Christina Quast <contact@...istina-quast.de>
> ---
>   drivers/staging/rtl8192e/Kconfig             |   1 +
>   drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 187 ++++++++-----------
>   2 files changed, 78 insertions(+), 110 deletions(-)

Tested-by: Larry Finger <Larry.finger@...inger.net>

This change for the RTL8192E works. I do not have the hardware for testing the 
equivalent change for r8192u, but as the changes look the same, that one is 
likely OK as well.

Thanks for the change,

Larry