linux-kernel - Re: [PATCH] uprobes/x86: fix detection of 32-bit user mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1908192042190.1796@nanos.tec.linutronix.de>
Date:   Mon, 19 Aug 2019 20:43:03 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Sebastian Mayr <me@....st>
cc:     Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] uprobes/x86: fix detection of 32-bit user mode

On Mon, 19 Aug 2019, Sebastian Mayr wrote:
> > @@ -1056,7 +1056,7 @@ bool arch_uprobe_skip_sstep(struct arch_uprobe
> > *auprobe, struct pt_regs *regs)
> >  unsigned long
> >  arch_uretprobe_hijack_return_addr(unsigned long trampoline_vaddr,
> > struct pt_regs *regs)
> >  {
> > -	int rasize = sizeof_long(), nleft;
> > +	int rasize = sizeof_long(regs), nleft;
> >  	unsigned long orig_ret_vaddr = 0; /* clear high bits for 32-bit 
> > apps */
> >  
> >  	if (copy_from_user(&orig_ret_vaddr, (void __user *)regs->sp,
> > rasize))
> 
> Any feedback on this patch would be greatly appreciated.

Sorry, fell through the cracks. Thanks for the reminder!