linux-kernel - Re: [PATCH v2 1/4] leds: lm3532: Fix brightness control for i2c mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <522f9394-22cf-f58b-b9fd-b345e9fd61b0@ti.com>
Date:   Tue, 20 Aug 2019 10:52:18 -0500
From:   Dan Murphy <dmurphy@...com>
To:     Pavel Machek <pavel@....cz>
CC:     <jacek.anaszewski@...il.com>, <tony@...mide.com>, <sre@...nel.org>,
        <nekit1000@...il.com>, <mpartap@....net>, <merlijn@...zup.org>,
        <linux-leds@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/4] leds: lm3532: Fix brightness control for i2c mode

Pavel

On 8/19/19 5:48 AM, Pavel Machek wrote:
> On Tue 2019-08-13 13:11:51, Dan Murphy wrote:
>> Fix the brightness control for I2C mode.  Instead of
>> changing the full scale current register update the ALS target
>> register for the appropriate banks.
>>
>> In addition clean up some code errors and random misspellings found
>> during coding.
>>
>> Tested on Droid4 as well as LM3532 EVM connected to a BeagleBoneBlack
>>
>> Fixes: e37a7f8d77e1 ("leds: lm3532: Introduce the lm3532 LED driver")
>> Reported-by: Pavel Machek <pavel@....cz>
>> Signed-off-by: Dan Murphy <dmurphy@...com>
> I may prefer register renames to come separately, but ...

I can separate them into a different patch

Dan


> Acked-by: Pavel Machek <pavel@....cz>
> 								Pavel