[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAL_JsqKvzogi9969fx9j6v58V5+EH-06tDx7-qy7xu84pGRSRA@mail.gmail.com>
Date: Tue, 20 Aug 2019 10:54:18 -0500
From: Rob Herring <robh@...nel.org>
To: "Ramuthevar,Vadivel MuruganX"
<vadivel.muruganx.ramuthevar@...ux.intel.com>
Cc: Kishon Vijay Abraham I <kishon@...com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
devicetree@...r.kernel.org,
Andy Shevchenko <andriy.shevchenko@...el.com>,
cheol.yong.kim@...el.com, qi-ming.wu@...el.com,
peter.harliman.liem@...el.com
Subject: Re: [PATCH v2 1/2] dt-bindings: phy: intel-emmc-phy: Add YAML schema
for LGM eMMC PHY
On Tue, Aug 20, 2019 at 5:31 AM Ramuthevar,Vadivel MuruganX
<vadivel.muruganx.ramuthevar@...ux.intel.com> wrote:
>
> From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@...ux.intel.com>
>
> Add a YAML schema to use the host controller driver with the
> eMMC PHY on Intel's Lightning Mountain SoC.
>
> Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@...ux.intel.com>
> ---
> changes in v2:
> As per Rob Herring review comments, the following updates
> - change GPL-2.0 -> (GPL-2.0-only OR BSD-2-Clause)
> - filename is the compatible string plus .yaml
> - LGM: Lightning Mountain
> - update maintainer
> - add intel,syscon under property list
> - keep one example instead of two
> ---
> .../bindings/phy/intel,lgm-emmc-phy.yaml | 72 ++++++++++++++++++++++
> 1 file changed, 72 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.yaml
>
> diff --git a/Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.yaml b/Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.yaml
> new file mode 100644
> index 000000000000..ec177573aca6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.yaml
> @@ -0,0 +1,72 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/phy/intel,lgm-emmc-phy.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Intel Lightning Mountain(LGM) eMMC PHY Device Tree Bindings
> +
> +maintainers:
> + - Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@...ux.intel.com>
> +
> +
> +description:
> + - Add a new compatible to use the host controller driver with the
> + eMMC PHY on Intel's Lightning Mountain SoC.
> +
> +$ref: /schemas/types.yaml#definitions/phandle
> + description:
> + - It also requires a "syscon" node with compatible = "intel,lgm-chiptop",
> + "syscon" to access the eMMC PHY register.
Not valid schema. Please build 'make dt_binding_check' and fix any warnings.
> +
> +properties:
> + "#phy-cells":
> + const: 0
> +
> + compatible:
> + const: intel,lgm-emmc-phy
> +
> + reg:
> + maxItems: 1
> +
> + intel,syscon:
> + items:
> + - description:
> + - |
> + e-MMC phy module should include the following properties
> + * reg, Access the e-MMC, get the base address from syscon.
> + * reset, reset the e-MMC module.
> +
> + clocks:
> + items:
> + - description: e-MMC phy module clock
> +
> + clock-names:
> + items:
> + - const: emmcclk
> +
> + resets:
> + maxItems: 1
> +
> +required:
> + - "#phy-cells"
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> + - resets
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + emmc_phy: emmc_phy {
> + compatible = "intel,lgm-emmc-phy";
> + reg = <0xe0020000 0x100>;
> + intel,syscon = <&sysconf>;
> + clocks = <&emmc>;
> + clock-names = "emmcclk";
> + #phy-cells = <0>;
> + };
> +
> +...
> --
> 2.11.0
>
Powered by blists - more mailing lists