[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAFBinCDP898fhoqh8wApfrsqAuv1dEQSoxy0yDA2hHKxoFsr+g@mail.gmail.com>
Date: Tue, 20 Aug 2019 22:17:48 +0200
From: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
To: Neil Armstrong <narmstrong@...libre.com>
Cc: davem@...emloft.net, robh+dt@...nel.org,
devicetree@...r.kernel.org, netdev@...r.kernel.org,
linux-amlogic@...ts.infradead.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
Rob Herring <robh@...nel.org>,
Maxime Ripard <maxime.ripard@...tlin.com>
Subject: Re: [PATCH net-next v4 1/2] dt-bindings: net: snps,dwmac: update reg
minItems maxItems
On Tue, Aug 20, 2019 at 9:57 AM Neil Armstrong <narmstrong@...libre.com> wrote:
>
> The Amlogic Meson DWMAC glue bindings needs a second reg cells for the
> glue registers, thus update the reg minItems/maxItems to allow more
> than a single reg cell.
>
> Also update the allwinner,sun7i-a20-gmac.yaml derivative schema to specify
> maxItems to 1.
this looks good to me because:
- allwinner,sun7i-a20-gmac.yaml now restricts reg to maxItems 1
- allwinner,sun8i-a83t-emac.yaml already restricts reg to maxItems 1
- amlogic,meson-dwmac.yaml (introduced in patch 2 from this series)
will need maxItems 2
- (these are all yaml based schemas for DWMAC IP)
> Signed-off-by: Neil Armstrong <narmstrong@...libre.com>
> Acked-by: Rob Herring <robh@...nel.org>
> Acked-by: Maxime Ripard <maxime.ripard@...tlin.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
Powered by blists - more mailing lists