linux-kernel - Re: [PATCH 15/15] riscv: disable the EFI PECOFF header for M-mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2c27e4f4a551720e2ca029743109eb02fe7d88e4.camel@wdc.com>
Date:   Tue, 20 Aug 2019 21:07:35 +0000
From:   Atish Patra <Atish.Patra@....com>
To:     "hch@....de" <hch@....de>,
        "paul.walmsley@...ive.com" <paul.walmsley@...ive.com>,
        "palmer@...ive.com" <palmer@...ive.com>
CC:     "linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>,
        Damien Le Moal <Damien.LeMoal@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 15/15] riscv: disable the EFI PECOFF header for M-mode

On Tue, 2019-08-13 at 17:47 +0200, Christoph Hellwig wrote:
> No point in bloating the kernel image with a bootloader header if
> we run bare metal.
> 
> Signed-off-by: Christoph Hellwig <hch@....de>
> ---
>  arch/riscv/kernel/head.S | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/riscv/kernel/head.S b/arch/riscv/kernel/head.S
> index 670e5cacb24e..09fcf3d000c0 100644
> --- a/arch/riscv/kernel/head.S
> +++ b/arch/riscv/kernel/head.S
> @@ -16,6 +16,7 @@
>  
>  __INIT
>  ENTRY(_start)
> +#ifndef CONFIG_M_MODE
>  	/*
>  	 * Image header expected by Linux boot-loaders. The image
> header data
>  	 * structure is described in asm/image.h.
> @@ -47,6 +48,7 @@ ENTRY(_start)
>  
>  .global _start_kernel
>  _start_kernel:
> +#endif /* CONFIG_M_MODE */
>  	/* Mask all interrupts */
>  	csrw CSR_XIE, zero
>  	csrw CSR_XIP, zero

Reviewed-by: Atish Patra <atish.patra@....com>

-- 
Regards,
Atish