linux-kernel - Re: [PATCH] media: saa7134: keep demod i2c gate open on Medion 7134

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6b772828-dd74-6d8e-3062-2c9438acfb89@maciej.szmigiero.name>
Date:   Tue, 20 Aug 2019 23:43:13 +0200
From:   "Maciej S. Szmigiero" <mail@...iej.szmigiero.name>
To:     Matthias Schwarzott <zzam@...too.org>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: saa7134: keep demod i2c gate open on Medion 7134

Hi Matthias,

On 20.08.2019 21:54, Matthias Schwarzott wrote:
> Hi Maciej,
> 
> some comment about wording in commit message and code-comment.
> 
> As far as I know the terms are defined like this:
> * gate open = i2c-clients behind gate can be reached
> * gate closed = i2c-clients behind gate are not reachable

I always thought that this terminology is like the one used for a switch:
if it is closed then the signal can pass, if open then it blocks the
signal but apparently it is literally like a physical gate, so you are
obviously right here - thanks for pointing this out.

Will respin this patch and also add a second one fixing the terminology
already present in saa7134_i2c_eeprom_md7134_gate().

> Regards
> Matthias

Regards,
Maciej