linux-kernel - Re: [RFC PATCH 08/15] drivers/acrn: add VM memory management for ACRN char device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1896e9f8-7947-3c7a-4328-ddbdeee892e3@intel.com>
Date:   Tue, 20 Aug 2019 10:25:51 +0800
From:   "Zhao, Yakui" <yakui.zhao@...el.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        Jason Chen CJ <jason.cj.chen@...el.com>
Subject: Re: [RFC PATCH 08/15] drivers/acrn: add VM memory management for ACRN
 char device



On 2019年08月19日 15:39, Dan Carpenter wrote:
> On Mon, Aug 19, 2019 at 01:32:54PM +0800, Zhao, Yakui wrote:
>> In fact as this driver is mainly used for embedded IOT usage, it doesn't
>> handle the complex cleanup when such error is encountered. Instead the clean
>> up is handled in free_guest_vm.
> 
> A use after free here seems like a potential security problem.  Security
> matters for IoT...  :(

Thanks for pointing out the issue.
The cleanup will be considered carefully.

> 
> regards,
> dan carpenter
>