[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190820093415.GF23903@e119886-lin.cambridge.arm.com>
Date: Tue, 20 Aug 2019 10:34:16 +0100
From: Andrew Murray <andrew.murray@....com>
To: Krzysztof Wilczynski <kw@...ux.com>
Cc: Bjorn Helgaas <helgaas@...nel.org>,
Thomas Gleixner <tglx@...utronix.de>,
Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/PCI: Remove surplus return from a void function
On Tue, Aug 20, 2019 at 08:51:21AM +0200, Krzysztof Wilczynski wrote:
> Remove unnecessary empty return statement at the end of a void
> function in the arch/x86/kernel/quirks.c.
>
> Signed-off-by: Krzysztof Wilczynski <kw@...ux.com>
> ---
> arch/x86/kernel/quirks.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/x86/kernel/quirks.c b/arch/x86/kernel/quirks.c
> index 8451f38ad399..1daf8f2aa21f 100644
> --- a/arch/x86/kernel/quirks.c
> +++ b/arch/x86/kernel/quirks.c
> @@ -90,8 +90,6 @@ static void ich_force_hpet_resume(void)
> BUG();
> else
> printk(KERN_DEBUG "Force enabled HPET at resume\n");
> -
> - return;
> }
>
> static void ich_force_enable_hpet(struct pci_dev *dev)
> @@ -448,7 +446,6 @@ static void nvidia_force_enable_hpet(struct pci_dev *dev)
> dev_printk(KERN_DEBUG, &dev->dev, "Force enabled HPET at 0x%lx\n",
> force_hpet_address);
> cached_dev = dev;
> - return;
> }
>
> /* ISA Bridges */
> @@ -513,7 +510,6 @@ static void e6xx_force_enable_hpet(struct pci_dev *dev)
> force_hpet_resume_type = NONE_FORCE_HPET_RESUME;
> dev_printk(KERN_DEBUG, &dev->dev, "Force enabled HPET at "
> "0x%lx\n", force_hpet_address);
> - return;
> }
> DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_E6XX_CU,
> e6xx_force_enable_hpet);
> --
Reviewed-by: Andrew Murray <andrew.murray@....com>
> 2.22.1
>
Powered by blists - more mailing lists