[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190820094306.GC24154@infradead.org>
Date: Tue, 20 Aug 2019 02:43:06 -0700
From: Christoph Hellwig <hch@...radead.org>
To: Tom Murphy <murphyt7@....ie>
Cc: iommu@...ts.linux-foundation.org, Heiko Stuebner <heiko@...ech.de>,
virtualization@...ts.linux-foundation.org,
linux-tegra@...r.kernel.org,
Thierry Reding <thierry.reding@...il.com>,
Will Deacon <will@...nel.org>,
Jean-Philippe Brucker <jean-philippe@...aro.org>,
linux-samsung-soc@...r.kernel.org,
Krzysztof Kozlowski <krzk@...nel.org>,
Jonathan Hunter <jonathanh@...dia.com>,
linux-rockchip@...ts.infradead.org, Andy Gross <agross@...nel.org>,
Gerald Schaefer <gerald.schaefer@...ibm.com>,
linux-s390@...r.kernel.org, linux-arm-msm@...r.kernel.org,
linux-mediatek@...ts.infradead.org,
Matthias Brugger <matthias.bgg@...il.com>,
linux-arm-kernel@...ts.infradead.org,
David Woodhouse <dwmw2@...radead.org>,
linux-kernel@...r.kernel.org, Kukjin Kim <kgene@...nel.org>,
Robin Murphy <robin.murphy@....com>
Subject: Re: [PATCH V5 3/5] iommu/dma-iommu: Handle deferred devices
> +static int handle_deferred_device(struct device *dev,
> + struct iommu_domain *domain)
Nitick: we usually use double tab indents (or indents to after
the opening brace) for multi-line prototyped.
> + if (!is_kdump_kernel())
> + return 0;
> +
> + if (unlikely(ops->is_attach_deferred &&
> + ops->is_attach_deferred(domain, dev)))
> + return iommu_attach_device(domain, dev);
And for multi-line conditionals we also use two-tab indents.
Powered by blists - more mailing lists