linux-kernel - Re: [PATCH v3 0/6] perf: Replace MAX_NR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190820100154.GJ2332@hirez.programming.kicks-ass.net>
Date:   Tue, 20 Aug 2019 12:01:54 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Kyle Meyer <meyerk@....com>
Cc:     Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        linux-kernel@...r.kernel.org,
        Russ Anderson <russ.anderson@....com>,
        Kyle Meyer <kyle.meyer@....com>
Subject: Re: [PATCH v3 0/6] perf: Replace MAX_NR_CPUS with dynamic
 alternatives

On Mon, Aug 19, 2019 at 03:22:41PM -0500, Kyle Meyer wrote:
> The purpose of this patch series is to replace MAX_NR_CPUS with a dynamic value
> throughout perf wherever possible using nr_cpus_online, the number of CPUs
> online during a record session, and cpu__max_cpu, the possible number of CPUs as
> defined in the sysfs. MAX_NR_CPUS is still used by DECLARE_BITMAP at compile
> time, however, it's replaced elsewhere.
> 
> This patch series was tested using "perf record -a -g" on both an eight socket
> (288 CPU) system and a single socket (36 CPU) system. Each system was then
> rebooted single socket and eight socket before "perf report" was used to read
> the perf.data out file. "perf report --header" was used to confirm that each
> perf.data file had information on the correct number of CPUs.
> 
> Change since v1:
>   Broke PATCH 2/2 into multiple patches.
> 
> Changes since v2:
>   Replaced env->sibling_cores and env->sibling threads with a local pointer and
>   refreshed perf/util/svghelper.
> 
>   Kyle Meyer (6):
>     perf: Refactor svg_build_topology_map
>     perf/util/svghelper: Replace MAX_NR_CPUS with env->nr_cpus_online
>     perf/util/stat: Replace MAX_NR_CPUS with cpu__max_cpu
>     perf/util/session: Replace MAX_NR_CPUS with nr_cpus_online
>     perf/util/machine: Replace MAX_NR_CPUS with nr_cpus_online
>     perf/util/header: Replace MAX_NR_CPUS with cpu__max_cpu

Your series isn't threaed; please play with your git-sendmail (or
whatever other tool you use) arguments.