linux-kernel - Re: [PATCH 2/2] ASoC: wm8904: implement input mode select as a mux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190820105033.GG10308@ediswmail.ad.cirrus.com>
Date:   Tue, 20 Aug 2019 10:50:33 +0000
From:   Charles Keepax <ckeepax@...nsource.cirrus.com>
To:     Michał Mirosław <mirq-linux@...e.qmqm.pl>
CC:     <alsa-devel@...a-project.org>, Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        zhong jiang <zhongjiang@...wei.com>,
        <patches@...nsource.cirrus.com>, <linux-kernel@...r.kernel.org>,
        Allison Randal <allison@...utok.net>
Subject: Re: [PATCH 2/2] ASoC: wm8904: implement input mode select as a mux

On Tue, Aug 20, 2019 at 12:33:33PM +0200, Michał Mirosław wrote:
> Make '* Capture Mode' a mux. This makes DAPM know that in single-ended
> mode only inverting mux paths need to be enabled.
> 
> Signed-off-by: Michał Mirosław <mirq-linux@...e.qmqm.pl>
> ---
> +static const struct snd_kcontrol_new rin_mode =
> +	SOC_DAPM_ENUM("right Capture Mode", rin_mode_enum);

Minor nit missing a captial on the right here.

Otherwise looks good:

Acked-by: Charles Keepax <ckeepax@...nsource.cirrus.com>

Thanks,
Charles