[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190820132649.GD29225@mellanox.com>
Date: Tue, 20 Aug 2019 13:26:53 +0000
From: Jason Gunthorpe <jgg@...lanox.com>
To: Dan Williams <dan.j.williams@...el.com>
CC: Christoph Hellwig <hch@....de>,
Bharata B Rao <bharata@...ux.ibm.com>,
Andrew Morton <akpm@...ux-foundation.org>,
Linux MM <linux-mm@...ck.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
linux-nvdimm <linux-nvdimm@...ts.01.org>,
Ira Weiny <ira.weiny@...el.com>
Subject: Re: [PATCH 2/4] memremap: remove the dev field in struct dev_pagemap
On Mon, Aug 19, 2019 at 06:44:02PM -0700, Dan Williams wrote:
> On Sun, Aug 18, 2019 at 2:12 AM Christoph Hellwig <hch@....de> wrote:
> >
> > The dev field in struct dev_pagemap is only used to print dev_name in
> > two places, which are at best nice to have. Just remove the field
> > and thus the name in those two messages.
> >
> > Signed-off-by: Christoph Hellwig <hch@....de>
> > Reviewed-by: Ira Weiny <ira.weiny@...el.com>
>
> Needs the below as well.
>
> /me goes to check if he ever merged the fix to make the unit test
> stuff get built by default with COMPILE_TEST [1]. Argh! Nope, didn't
> submit it for 5.3-rc1, sorry for the thrash.
>
> You can otherwise add:
>
> Reviewed-by: Dan Williams <dan.j.williams@...el.com>
>
> [1]: https://lore.kernel.org/lkml/156097224232.1086847.9463861924683372741.stgit@dwillia2-desk3.amr.corp.intel.com/
Can you get this merged? Do you want it to go with this series?
Jason
Powered by blists - more mailing lists