linux-kernel - Re: [PATCH] selftests: bpf: install files test_xdp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190820160726.5a8990c8@carbon>
Date:   Tue, 20 Aug 2019 16:07:26 +0200
From:   Jesper Dangaard Brouer <jbrouer@...hat.com>
To:     Anders Roxell <anders.roxell@...aro.org>
Cc:     shuah@...nel.org, ast@...nel.org, daniel@...earbox.net,
        davem@...emloft.net, jakub.kicinski@...ronome.com, hawk@...nel.org,
        john.fastabend@...il.com, linux-kselftest@...r.kernel.org,
        netdev@...r.kernel.org, bpf@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftests: bpf: install files test_xdp_vlan.sh

On Tue, 20 Aug 2019 15:41:21 +0200
Anders Roxell <anders.roxell@...aro.org> wrote:

> When ./test_xdp_vlan_mode_generic.sh runs it complains that it can't
> find file test_xdp_vlan.sh.
> 
>  # selftests: bpf: test_xdp_vlan_mode_generic.sh
>  # ./test_xdp_vlan_mode_generic.sh: line 9: ./test_xdp_vlan.sh: No such
>  file or directory
> 
> Rework so that test_xdp_vlan.sh gets installed, added to the variable
> TEST_PROGS_EXTENDED.
> 
> Fixes: d35661fcf95d ("selftests/bpf: add wrapper scripts for test_xdp_vlan.sh")
> Signed-off-by: Anders Roxell <anders.roxell@...aro.org>
> ---

Thanks for catching this!

Acked-by: Jesper Dangaard Brouer <jbrouer@...hat.com>

>  tools/testing/selftests/bpf/Makefile | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
> index 1faad0c3c3c9..d7968e20463c 100644
> --- a/tools/testing/selftests/bpf/Makefile
> +++ b/tools/testing/selftests/bpf/Makefile
> @@ -68,7 +68,8 @@ TEST_PROGS := test_kmod.sh \
>  TEST_PROGS_EXTENDED := with_addr.sh \
>  	with_tunnels.sh \
>  	tcp_client.py \
> -	tcp_server.py
> +	tcp_server.py \
> +	test_xdp_vlan.sh
>  
>  # Compile but not part of 'make run_tests'
>  TEST_GEN_PROGS_EXTENDED = test_libbpf_open test_sock_addr test_skb_cgroup_id_user \



-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer