linux-kernel - Re: [PATCH] cpustat: print watchdog time and statistics of soft and hard interrupts in soft lockup scenes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4eb6b499-b6b0-602a-ae89-0c1dceaa5088@huawei.com>
Date:   Wed, 21 Aug 2019 16:26:17 +0800
From:   c00423981 <caomeng5@...wei.com>
To:     Peter Zijlstra <peterz@...radead.org>
CC:     <tglx@...utronix.de>, <mingo@...hat.com>, <hpa@...or.com>,
        <x86@...nel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cpustat: print watchdog time and statistics of soft and
 hard interrupts in soft lockup scenes

Sorry, I cannot understand this problem accurately. I try to understand it and I guess what you want
to express is that the return value type should be cputime64_t but not u64, just like as follows:

+static cputime64_t cpustat_curr_cputime(int cpu, int index)
+{
+	cputime64_t time;
+
+	if (index == CPUTIME_IDLE)
+		time = get_idle_time(cpu);
+	else if (index == CPUTIME_IOWAIT)
+		time = get_iowait_time(cpu);

I don't know if I understand it correctly. Looking forward to your answer.




On 2019/8/20 19:04, Peter Zijlstra wrote:
> On Mon, Aug 19, 2019 at 03:12:24PM +0800, c00423981 wrote:
>> +static u64 cpustat_curr_cputime(int cpu, int index)
>> +{
>> +	u64 time;
>> +
>> +	if (index == CPUTIME_IDLE)
>> +		time = get_idle_time(cpu);
>> +	else if (index == CPUTIME_IOWAIT)
>> +		time = get_iowait_time(cpu);
> 
> NAK; don't add new users of this terminally broken interface.
> 
>