linux-kernel - Re: [PATCH v12 6/9] ARM: dts: exynos: add chipid label and syscon compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8cee8885-142f-d508-472b-334a73d30696@partner.samsung.com>
Date:   Wed, 21 Aug 2019 11:29:08 +0200
From:   Lukasz Luba <l.luba@...tner.samsung.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-pm@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
        linux-clk@...r.kernel.org, mturquette@...libre.com,
        sboyd@...nel.org, b.zolnierkie@...sung.com, kgene@...nel.org,
        mark.rutland@....com, robh+dt@...nel.org, cw00.choi@...sung.com,
        kyungmin.park@...sung.com, m.szyprowski@...sung.com,
        s.nawrocki@...sung.com, myungjoo.ham@...sung.com,
        keescook@...omium.org, tony@...mide.com, jroedel@...e.de,
        treding@...dia.com, digetx@...il.com, gregkh@...uxfoundation.org,
        willy.mh.wolff.ml@...il.com
Subject: Re: [PATCH v12 6/9] ARM: dts: exynos: add chipid label and syscon
 compatible



On 7/24/19 7:10 PM, Krzysztof Kozlowski wrote:
> On Mon, Jul 22, 2019 at 11:46:43AM +0200, Lukasz Luba wrote:
>> Add the chipid label which allows to use it in phandle from other device.
>> Use syscon in compatible to get the regmap of the device register set.
>> The chipid is used in DMC during initialization to compare compatibility.
>>
> 
> I cannot find its usage in DMC driver.
You are right, it was used in the old versions. I will skip this patch.

Regards,
Lukasz
> 
> Best regards,
> Krzysztof
> 
> 
>> Signed-off-by: Lukasz Luba <l.luba@...tner.samsung.com>
>> ---
>>   arch/arm/boot/dts/exynos5.dtsi | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5.dtsi b/arch/arm/boot/dts/exynos5.dtsi
>> index 67f9b4504a42..4801ca759feb 100644
>> --- a/arch/arm/boot/dts/exynos5.dtsi
>> +++ b/arch/arm/boot/dts/exynos5.dtsi
>> @@ -35,8 +35,8 @@
>>   		#size-cells = <1>;
>>   		ranges;
>>   
>> -		chipid@...00000 {
>> -			compatible = "samsung,exynos4210-chipid";
>> +		chipid: chipid@...00000 {
>> +			compatible = "samsung,exynos4210-chipid", "syscon";
>>   			reg = <0x10000000 0x100>;
>>   		};
>>   
>> -- 
>> 2.17.1
>>
> 
>