linux-kernel - Re: [PATCH v2] mt76: fix some checkpatch warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5613f082389460cb8de4251c08038c914683bd49.camel@perches.com>
Date:   Wed, 21 Aug 2019 04:59:16 -0700
From:   Joe Perches <joe@...ches.com>
To:     Ryder Lee <ryder.lee@...iatek.com>, Felix Fietkau <nbd@....name>,
        Lorenzo Bianconi <lorenzo.bianconi@...hat.com>
Cc:     Roy Luo <royluo@...gle.com>, YF Luo <yf.luo@...iatek.com>,
        Yiwei Chung <yiwei.chung@...iatek.com>,
        Sean Wang <sean.wang@...iatek.com>,
        linux-wireless@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mt76: fix some checkpatch warnings

On Wed, 2019-08-21 at 11:11 +0800, Ryder Lee wrote:
> This fixes the following checkpatch warnings:
> CHECK: Alignment should match open parenthesis
> CHECK: No space is necessary after a cast
> 
> Signed-off-by: Ryder Lee <ryder.lee@...iatek.com>
> ---
> Changes since v2: remove false positive checkpatch warnings.

What were those?

> diff --git a/drivers/net/wireless/mediatek/mt76/dma.c b/drivers/net/wireless/mediatek/mt76/dma.c
[]
> @@ -587,8 +589,8 @@ mt76_check_sta(struct mt76_dev *dev, struct sk_buff *skb)
>  	}
>  
>  	if (ieee80211_has_morefrags(hdr->frame_control) ||
> -		!(ieee80211_is_mgmt(hdr->frame_control) ||
> -		  ieee80211_is_data(hdr->frame_control)))
> +	    !(ieee80211_is_mgmt(hdr->frame_control) ||
> +	    ieee80211_is_data(hdr->frame_control)))

Poor alignment here.

This should be:

	if (ieee80211_has_morefrags(hdr->frame_control) ||
	    !(ieee80211_is_mgmt(hdr->frame_control) ||
	      ieee80211_is_data(hdr->frame_control)))