linux-kernel - Re: [PATCH] tools/power: intel-speed-select: Fix a read overflow in isst_set_tdp_level

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1b68045227e852fb2f250d0ec858ae006490123f.camel@linux.intel.com>
Date:   Wed, 21 Aug 2019 09:20:24 -0700
From:   Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH] tools/power: intel-speed-select:  Fix a read overflow
 in isst_set_tdp_level_msr()

On Wed, 2019-08-21 at 10:14 +0300, Dan Carpenter wrote:
> The isst_send_msr_command() function will read 8 bytes but we are
> passing an address to an int (4 bytes) so it results in a read
> overflow.
> 
> Fixes: 3fb4f7cd472c ("tools/power/x86: A tool to validate Intel Speed
> Select commands")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>

> ---
>  tools/power/x86/intel-speed-select/isst-core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/power/x86/intel-speed-select/isst-core.c
> b/tools/power/x86/intel-speed-select/isst-core.c
> index 8de4ac39a008..f724322856ed 100644
> --- a/tools/power/x86/intel-speed-select/isst-core.c
> +++ b/tools/power/x86/intel-speed-select/isst-core.c
> @@ -190,6 +190,7 @@ int isst_get_get_trl(int cpu, int level, int
> avx_level, int *trl)
>  
>  int isst_set_tdp_level_msr(int cpu, int tdp_level)
>  {
> +	unsigned long long level = tdp_level;
>  	int ret;
>  
>  	debug_printf("cpu: tdp_level via MSR %d\n", cpu, tdp_level);
> @@ -202,8 +203,7 @@ int isst_set_tdp_level_msr(int cpu, int
> tdp_level)
>  	if (tdp_level > 2)
>  		return -1; /* invalid value */
>  
> -	ret = isst_send_msr_command(cpu, 0x64b, 1,
> -				    (unsigned long long *)&tdp_level);
> +	ret = isst_send_msr_command(cpu, 0x64b, 1, &level);
>  	if (ret)
>  		return ret;
>