lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <c33a07f7-6fc3-d8b9-7a2f-c4835ba2082f@collabora.com>
Date:   Wed, 21 Aug 2019 19:50:15 +0200
From:   Enric Balletbo i Serra <enric.balletbo@...labora.com>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     linux-kernel@...r.kernel.org, Jonathan Corbet <corbet@....net>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Will Deacon <will.deacon@....com>,
        MyungJoo Ham <myungjoo.ham@...sung.com>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Benson Leung <bleung@...omium.org>,
        Guenter Roeck <groeck@...omium.org>,
        Jonathan Cameron <jic23@...nel.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Sebastian Reichel <sre@...nel.org>,
        Thierry Reding <thierry.reding@...il.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Neil Armstrong <narmstrong@...libre.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Collabora kernel ML <kernel@...labora.com>,
        Gwendal Grignou <gwendal@...omium.org>
Subject: Re: [PATCH v5 10/11] mfd: cros_ec: Use mfd_add_hotplug_devices()
 helper

Hi Lee,

On 12/8/19 9:24, Lee Jones wrote:
> On Mon, 22 Jul 2019, Enric Balletbo i Serra wrote:
> 
>> Use mfd_add_hotplug_devices() helper to register the subdevices.
> 
> You need to state why this change is useful/required.
> 

The reason for this change is to avoid a bit of boiler plate and be coherent
with the new functions created to register subdevices, as Gwendal pointed to use
that. I'll make explicit in the commit comment on next version.

Thanks,
Enric

>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
>> Reviewed-by: Gwendal Grignou <gwendal@...omium.org>
>> Tested-by: Gwendal Grignou <gwendal@...omium.org>
>> ---
>>
>> Changes in v5: None
>> Changes in v4: None
>> Changes in v3:
>> - Add a new patch to use mfd_add_hoplug_devices to register subdevices
>>
>> Changes in v2: None
>>
>>  drivers/mfd/cros_ec_dev.c | 18 ++++++------------
>>  1 file changed, 6 insertions(+), 12 deletions(-)
> 

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ