linux-kernel - Re: [PATCH v2 4/6] dt-bindings: serial: Document Freescale LINFlex UART

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 22 Aug 2019 17:41:07 +0000
From:   Stefan-gabriel Mirea <stefan-gabriel.mirea@....com>
To:     Rob Herring <robh@...nel.org>
CC:     "corbet@....net" <corbet@....net>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "catalin.marinas@....com" <catalin.marinas@....com>,
        "will@...nel.org" <will@...nel.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        Leo Li <leoyang.li@....com>,
        "jslaby@...e.com" <jslaby@...e.com>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Cosmin Stefan Stoica <cosmin.stoica@....com>,
        Larisa Ileana Grigore <larisa.grigore@....com>
Subject: Re: [PATCH v2 4/6] dt-bindings: serial: Document Freescale LINFlex
 UART

Hello Rob,

Thank you for the review.

On 8/22/2019 12:18 AM, Rob Herring wrote:
> On Fri, Aug 09, 2019 at 11:29:14AM +0000, Stefan-gabriel Mirea wrote:
>> +* Freescale Linflex UART
> 
> Be consistent with the name: LINFlexD?

This was also brought up in our internal review. However, the reference
manual is also inconsistent, using LINFlexD, LINflexD, LinFlexD,
LINFlex, LINFLEX, LinFlex and Linflex. I will switch to 'LINFlexD'
everywhere, though.

>> +The LINFlexD controller implements several LIN protocol versions, as well as
>> +support for full-duplex UART communication through 8-bit and 9-bit frames. The
>> +Linflex UART driver enables operation only in UART mode.
> 
> What the driver supports or not is independent of the binding.

Ok, I will remove the last sentence ("The Linflex UART driver enables
operation only in UART mode").

>> +  - "fsl,s32-linflexuart" for linflex configured in uart mode which
> 
> LINFlexD?

Will fix; I agree that the all lowercase version has no occurrence in
the reference manual.

>> +  is compatible with the one integrated on S32V234 SoC
> 
> Compatibles should be SoC specific. Is 's32' specific enough to account
> for any differences or future bugs found?

It is probably not. I will change it to "fsl,s32v234-linflexuart" (as
well as in the device tree and driver).

>> +Example:
>> +uart0:serial@...53000 {
> 
> space    ^
> 
>> +     compatible = "fsl,s32-linflexuart";
>> +     reg = <0x0 0x40053000 0x0 0x1000>;
>> +     interrupts = <0 59 4>;
>> +     status = "disabled";
> 
> Don't show status in examples.

Will fix these too.

Regards,
Stefan