linux-kernel - Re: [PATCH v4 2/4] nvme-pci: Add support for variable IO SQ element size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4fc11568-73fe-c8b5-ac29-d49daee9abad@grimberg.me>
Date:   Thu, 22 Aug 2019 11:02:08 -0700
From:   Sagi Grimberg <sagi@...mberg.me>
To:     Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Christoph Hellwig <hch@....de>
Cc:     linux-nvme@...ts.infradead.org, Jens Axboe <axboe@...com>,
        Keith Busch <keith.busch@...el.com>,
        linux-kernel@...r.kernel.org, Paul Pawlowski <paul@...rm.io>
Subject: Re: [PATCH v4 2/4] nvme-pci: Add support for variable IO SQ element
 size


>> wrote:
>>> +#define NVME_NVM_ADMSQES	6
>>>   #define NVME_NVM_IOSQES		6
>>>   #define NVME_NVM_IOCQES		4
>>
>> The NVM in the two defines here stands for the NVM command set,
>> so this should just be named NVME_ADM_SQES or so.  But except for
>> this
>> the patch looks good:
>>
>> Reviewed-by: Christoph Hellwig <hch@....de>
>>
>> So maybe Sagi can just fix this up in the tree.
> 
> Ah ok I missed the meaning. Thanks. Sagi, can you fix that up or do you
> need me to resubmit ?

I'll fix it. Note that I'm going to take it out of the tree soon
because it will have conflicts with Jens for-5.4/block, so we
will send it to Jens after the initial merge window, after he
rebases off of Linus.