linux-kernel - Re: [PATCH V2] perf/x86: Consider pinned events for group validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190822182227.GD5447@tassilo.jf.intel.com>
Date:   Thu, 22 Aug 2019 11:22:27 -0700
From:   Andi Kleen <ak@...ux.intel.com>
To:     kan.liang@...ux.intel.com
Cc:     peterz@...radead.org, mingo@...hat.com, acme@...nel.org,
        linux-kernel@...r.kernel.org, eranian@...gle.com
Subject: Re: [PATCH V2] perf/x86: Consider pinned events for group validation

> +	/*
> +	 * Disable interrupts to prevent the events in this CPU's cpuc
> +	 * going away and getting freed.
> +	 */
> +	local_irq_save(flags);

I believe it's also needed to disable preemption. Probably should
add a comment, or better an explicit preempt_disable() too.

-Andi